London | 26-ITP-May | Vito Moratti | Sprint 1 | Module data groups/sprint1 by vmoratti · Pull Request #1297 · CodeYourFuture/Module-Data-Groups

vmoratti · 2026-07-26T16:24:55Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed exercises for Sprint 1 except for stretch, which i didn't have time for.

Questions

Stretch is optional right?

cjyuan · 2026-07-31T16:07:10Z

+  if (!Array.isArray(list) || list.length < 2) {
+    return null;
+  }


Why can't an array containing one number have a median?

cjyuan · 2026-07-31T16:10:39Z

+test("given an array with no duplicates, it returns a copy of the original array", () => {
+  expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]);
+});


Your function implementation is correct. However, this test could be improved to better ensure
that any future changes continue to align with the expected behavior described on line 25:

Then it should return a copy of the original array

This test should fail if the function returns the original array (instead of a copy of the original array).

The current test checks only if both the original array and the returned array contain identical elements.
In order to validate the returned array is a different array, we need an additional check.

Can you find out what this additional check is?

i have now added test to check if the returned array is a copy

cjyuan · 2026-07-31T16:16:38Z

@@ -1,4 +1,10 @@
 function sum(elements) {
+    let innit = 0;


What does the name innit mean?

I have changed the variable name to "counter"

cjyuan · 2026-07-31T16:17:27Z

+return innit; 
 }


Indentation is off.

Update median calculation to handle empty arrays.

vmoratti

fixed median function

cjyuan

Changes look good. I just have a few more suggestions.

cjyuan · 2026-08-02T17:11:15Z

+  if (filteredList.length < 1) {
+    return null;
+  }
+  const sortedList = filteredList.sort((a, b) => a - b);


Do explore the difference between .toSorted() and .sort().

cjyuan · 2026-08-02T17:13:56Z

+const original = [1, 2, 3];
+const result = dedupe(original);
+
+expect(result).toEqual([1, 2, 3]);
+expect(result).not.toBe(original);


This test is correct, but shouldn't it be defined at line 27?

cjyuan · 2026-08-02T17:17:04Z

@@ -1,4 +1,13 @@
 function sum(elements) {
+    let counter = 0;


Could also use total.

cjyuan · 2026-08-02T17:18:31Z

@@ -1,4 +1,13 @@
 function sum(elements) {
+    let counter = 0;
+    const filteredList = elements.filter((value) => typeof value === "number" && !isNaN(value) && isFinite(value));


Note: Number.isFinite() checks all three conditions.

vmoratti added 16 commits July 24, 2026 16:19

rewrite function

cae4a14

write function and create two tests

f9211a3

change function, write some tests

183be23

write test for decimal numbers

8e59e19

write test for mixed array of numbers and non-numbers

f9080a3

write test for mixed array of non-numbers

72267a0

add empty array test

4f2f012

write sum function

f48b3b9

add tests for negative and decimal numbers

4fe95d9

write test for mixed array

120a279

add validation to the function

a02f092

add test with non-number array

a22313c

add tests for an empty, and array wwith duplicates

dc82a68

write function

4522a37

add test with duplicates

c22b7f9

refactor includes function

8f921db

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 26, 2026

cjyuan reviewed Jul 31, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 31, 2026

vmoratti added 4 commits July 31, 2026 17:29

Fix median function to allow single element lists

0bfabe2

Update median calculation to handle empty arrays.

Fix indentation in dedupe function

23d816f

Update findMax to filter out NaN values

9fc3bd1

Fix median function to handle empty filtered list

ad1cb78

vmoratti commented Aug 1, 2026

View reviewed changes

vmoratti added 5 commits August 2, 2026 11:09

add test with 300 and new line

71b98b5

add test to chack for array identity

b58b9c2

remove if statement

6604d84

change varaible name to counter

67e3d31

add additional validation

64b4a38

vmoratti added 3 commits August 2, 2026 12:15

fix indentation

cba37a9

change floating point testing to .toBeCloseTo

4312a67

change variable name to element

0a9896d

vmoratti added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 2, 2026

cjyuan reviewed Aug 2, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

vmoratti commented Jul 26, 2026

Changelist

Questions

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vmoratti left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants