Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | debug - #1315
Open
Tobias-Amaechina wants to merge 49 commits into
Open
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | debug#1315Tobias-Amaechina wants to merge 49 commits into
Tobias-Amaechina wants to merge 49 commits into
Conversation
…d log out the value
…the explanations
…d print the value
…rue otherwise return false
… there is existence property name and when there is not
…le array of country code and return the corresponding currency code
…filetr out spaces
… , removed the comme and changed the correct variables
… date is only array
…alue and the second to find the value with the highest frequency
Tobias-Amaechina
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Tobias-Amaechina
changed the title
This comment has been minimized.
This comment has been minimized.
Tobias-Amaechina
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Tobias-Amaechina
changed the title
Tobias-Amaechina
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, I still see some formatting issues however. Also, when you run the tests, do you see any warnings of incomplete work?
| function createLookup(pairs) { | ||
| const lookup = {}; | ||
|
|
||
| for (let [country, currency] of pairs) { |
Author
There was a problem hiding this comment.
Thanks for the feedback
| }else{ | ||
| frequency[item] = 1 | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you check your formatting in this file and others?
Author
There was a problem hiding this comment.
Thanks for the feedback , The function has been refactored and formatted
LonMcGregor
added
Reviewed
Tobias-Amaechina
added
🏕 Priority Mandatory
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great, this looks much neater now. Good work
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
What I did encompassed the explanations below : Object & Array Manipulations: Implemented functions using for...in and for...of loops, bracket notation, and methods like Object.entries (e.g., inverting key-value pairs, calculating frequency tallies, and extracting country/currency data).
String Processing & Logic: Developed string parsing logic using regular expressions for cleaning punctuation, splitting text, and handling edge cases like empty strings.
Testing & Validation: Added comprehensive test suites using Jest to cover valid inputs, edge cases (empty arrays/strings), and invalid parameter types (numbers, arrays, strings).
Code Refactoring & Debugging: Refactored conditional checks, cleaned up console logs/assertions, and fixed variable assignments (let vs const) to improve code structure and maintainability.