Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Alarmclock App - #1321
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Alarmclock App#1321TTiamiyu wants to merge 6 commits into
Conversation
TTiamiyu
added
🏕 Priority Mandatory
Luro91
added
the
Review in progress
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
The title of the webpage should say Alarm clock app. It says Title here at the moment
|
|
||
| // If input is invalid or empty, default to 0 | ||
| if (isNaN(totalSeconds) || totalSeconds < 0) { | ||
| totalSeconds = 0; |
There was a problem hiding this comment.
I am not sure if the expected user behaviour for invalid inputs is to set the seconds to 0. What else could you do instead?
There was a problem hiding this comment.
i see what you mean, i could make it that an invalid input does not affect the present or ongoing timer by returning nothing with "return;' rather than what is presently there.
There was a problem hiding this comment.
@Luro91 the latest commits have addressed the reviews left on both the title and the behaviour of the app when an invalid input is made.
There was a problem hiding this comment.
When I try to start a negative countdown now it seems like the app is not responding. How could you provide a better user experience?
There was a problem hiding this comment.
i could add an error message, informing the user on what to do within the guidelines of the app, like "enter a number greater than 0"
Luro91
added
Reviewed
d0e8ded to
f8c455e
Compare
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Please always update the labels when you are done with your changes (to "review required) so that reviewers know that they should check again
There was a problem hiding this comment.
i made a mistake in the branching for the sprint 3 but i would try to rectify it.
…e immediate display update on button click
…ge as user feedback
5006d95 to
d61207f
Compare
TTiamiyu
added
the
Needs Review
2 participants
Learners, PR Template
Self checklist