London | 26-ITP-May | Zadri Abdule | Sprint 3 | Quote-generator - #1328
Open
Zadri415 wants to merge 2 commits into
Open
London | 26-ITP-May | Zadri Abdule | Sprint 3 | Quote-generator#1328Zadri415 wants to merge 2 commits into
Zadri415 wants to merge 2 commits into
Conversation
Zadri415
added
Needs Review
cjyuan
reviewed
Aug 1, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. Well done.
Comment on lines
+28
to
+29
| quoteEl.textContent = `"${chosen.quote}"`; | ||
| authorEl.textContent = `— ${chosen.author}`; |
Contributor
There was a problem hiding this comment.
The " and the leading — appear to be for styling purposes. Keeping them in the HTML or in CSS could make it easier to style or modify the view. This allows front-end developers to adjust the UI without changing any JavaScript code.
Comment on lines
+13
to
+30
| function showRandomQuote() { | ||
| let index; | ||
|
|
||
| if (quotes.length === 1) { | ||
| index = 0; | ||
| } else { | ||
| do { | ||
| index = Math.floor(Math.random() * quotes.length); | ||
| } while (index === lastIndex); | ||
| } | ||
|
|
||
| lastIndex = index; | ||
|
|
||
| const chosen = quotes[index]; | ||
|
|
||
| quoteEl.textContent = `"${chosen.quote}"`; | ||
| authorEl.textContent = `— ${chosen.author}`; | ||
| } |
Contributor
There was a problem hiding this comment.
Could probably separate the logic of selecting a random index (lines 14 to 24) from the presentation logic (lines 26-29).
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the sprint-3 quote generator task.