Skip to content

London | 26-ITP-May | Dagim Daniel | Sprint 3 | Alarm clock #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dagim-Daniel wants to merge 2 commits into
base: main
Choose a base branch
from
+64 −3
Open

London | 26-ITP-May | Dagim Daniel | Sprint 3 | Alarm clock #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e30ba62
tasks under Sprint 3 alarm has been done
Dagim-Daniel Jul 28, 2026
eeb63cd
cleaning code and fixing pre validation
Dagim-Daniel Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,65 @@
function setAlarm() {}
const display = document.querySelector("#timeRemaining");
const totalSeconds = document.querySelector("#alarmSet");
const setButton = document.querySelector("#set");
const stopButton = document.querySelector("#stop");
let conuntdownInterval;

function formatTime(totalSeconds) {
const minutes = Math.floor(totalSeconds / 60);
const seconds = totalSeconds % 60;

const paddedMinutes = String(minutes).padStart(2, "0");
const paddedSeconds = String(seconds).padStart(2, "0");
return `Time Remaining: ${paddedMinutes}:${paddedSeconds}`;
}

function reset() {
clearInterval(conuntdownInterval);
display.textContent = "Time Remaining: 00:00";
display.style.color = "black";
setButton.disabled = false;
document.body.style.background = "";
}
let countdownInterval;

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between this variable and the variable declared on line 6, one of them is not used and one of the them seems to be misspelled.

setButton.addEventListener("click", () => {
let timeleft = Number(totalSeconds.value);
Comment thread
cjyuan marked this conversation as resolved.

if (timeleft <= 0 || isNaN(timeleft)) {
alert("please enter a number greater than zero (0)!");
return;
}
Comment on lines +26 to +31

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of number should the input be?

setButton.disabled = true;

display.textContent = formatTime(timeleft);

const warningTime = 10; // seconds
clearInterval(conuntdownInterval);

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is clearing countdownInterval necessary before starting a new countdown?

If clearing it is necessary, then it is likely that we should also call reset() here.


conuntdownInterval = setInterval(() => {
timeleft--;
Comment on lines +34 to +40

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New countdown implementation is good. You could consider moving the statement that displays the initial time on line 34 to just before line 39 so that the code in the function reads more like:

// Process input

// Reset/initialize states

// Start countdown


if (timeleft >= 0) {
display.textContent = formatTime(timeleft);
}

if (timeleft <= warningTime) {
display.style.color = "red";
}

if (timeleft <= 0) {
clearInterval(conuntdownInterval);
document.body.style.backgroundColor = "grey";
playAlarm();
}
}, 1000);
Comment thread
cjyuan marked this conversation as resolved.
});

stopButton.addEventListener("click", () => {
clearInterval(conuntdownInterval);
reset();
pauseAlarm();
});
Comment on lines +58 to +62

@cjyuan cjyuan Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addEventListener() can add multiple event listeners (callbacks) to a DOM object.

Normally if we could modify all the code, we could just update the original callback (lines 73-75). Since we are adding another onclick callback to stopButton, we should avoid repeating the task performed by the original callback.


// DO NOT EDIT BELOW HERE

Expand Down
6 changes: 3 additions & 3 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm clock app</title>
</head>
<body>
<div class="centre">
Expand All @@ -15,6 +15,6 @@ <h1 id="timeRemaining">Time Remaining: 00:00</h1>
<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
</div>
<script src="alarmclock.js"></script>
<script src="alarmclock.js" defer></script>
</body>
</html>
Loading