Skip to content

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 1 | Form Controls #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SandzSoft wants to merge 7 commits into from
Closed

Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 1 | Form Controls #1288

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce896eb
Create Product Pick form
SandzSoft May 14, 2026
a4deffe
Add CSS styling for Product Pick form
SandzSoft May 14, 2026
f278f2c
Refine form details and validation
SandzSoft May 14, 2026
e26027f
Remove unwanted new lines
SandzSoft May 21, 2026
a877cc3
Improve form accessibility and responsive styling
SandzSoft May 27, 2026
de00a67
Improve form accessibility in html
SandzSoft May 27, 2026
8a64dd7
Add meta description for improved SEO
SandzSoft May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 42 additions & 6 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,61 @@
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<link rel="stylesheet" href="./style.css">
<title>Product Pick Form</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<div class="container">
<header>

@Luro91 Luro91 May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard is to use intendation for children elements to make it easer to understand the html structure.How can you ensure consistent formatting in your code automatically?

@SandzSoft SandzSoft May 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can ensure consistent formatting automatically by using a code formatter like Prettier in VS Code with “format on save” enabled, so indentation and structure are cleaned automatically every time I save the file.

<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<div class="field">
<label for="customer_name">Name :</label>
<input minlength="2" required type="text" id="customer_name" name="customer_name">

@Luro91 Luro91 May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on the validation

</div>
<div class="field">
<label for="email">Email :</label>
<input required type="email" name="email" id="email">
</div>
<div class="field">
<label for="colour">Colour choice :</label>
<select required id="colour" name="colour">
<option disabled selected value="">--Please Select--</option>
<option value="red">Red</option>
<option value="black">Black</option>
<option value="white">White</option>
</select>
</div>
<div class="field">
<label for="size">Size :</label>
<select required id="size" name="size">
<option disabled selected value="">--Please Select--</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</div>

<div class="submit_field">
<input class="submit_button" type="submit" value="Submit">
</div>




@Luro91 Luro91 May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new lines are not needed.

@SandzSoft SandzSoft May 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. I've removed the unnecessary blank lines.

</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>SandzSoft</p>
</footer>
</div>
</body>
</html>
63 changes: 63 additions & 0 deletions Form-Controls/style.css
View file
Open in desktop

@Luro91 Luro91 May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice styling of the form. I like how it looks

Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
body {
margin: 0;
padding: 10px;
font-family: 'Segoe UI', sans-serif;
display: flex;
justify-content: center;
}

.container {
background-color: #bfbfbf;
width: 500px;
padding: 35px;
font-size: 16px;
border-radius: 10px;
}

header {
background: #4f46e5;
color: white;
padding: 15px 30px;
display: flex;
align-items: center;
box-shadow: 0 2px 10px rgba(0,0,0,0.1);
}

header h1 {
margin: 0;
font-size: 20px;
}

.field {
background-color: #f1f1f1;
padding: 10px;
border: 2px solid white;
display: flex;
align-items: center;
gap: 10px;
margin-bottom: 5px;
}

label {
width: 150px;
}

input,
select {
flex: 1;
padding: 6px;
}

.submit_field {
text-align: right;
margin-top: 10px;
}

.submit_button {
background-color: skyblue;
padding: 10px 20px;
border-radius: 8px;
border: none;
cursor: pointer;
font-weight: bold;
}
Loading