Manchester | 26-ITP-May | Yee Man Tsang | Sprint 3 | 1-implement-and-rewrite-tests - #1496
Open
lintsang wants to merge 4 commits into
Open
Manchester | 26-ITP-May | Yee Man Tsang | Sprint 3 | 1-implement-and-rewrite-tests#1496lintsang wants to merge 4 commits into
lintsang wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
lintsang
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
lintsang
added
the
Needs Review
Liam310
added
Review in progress
Liam310
reviewed
Jul 14, 2026
Liam310
reviewed
Jul 14, 2026
Liam310
reviewed
Jul 14, 2026
Liam310
reviewed
Jul 14, 2026
Liam310
reviewed
Jul 14, 2026
Liam310
reviewed
Jul 14, 2026
Liam310
added
Reviewed
lintsang
added
the
Needs Review
Liam310
reviewed
Jul 28, 2026
Liam310
reviewed
Jul 28, 2026
|
Great work @lintsang! Just one comment I don't think you quite resolved and I've left a couple of other small ones. Almost there now 🙂 |
Author
|
Many thanks to your feedback Liam |
Liam310
reviewed
Jul 31, 2026
| case "8": | ||
| case "9": | ||
| case "10": | ||
| console.log(number); |
There was a problem hiding this comment.
A rogue console.log has appeared again! Watch out for these when you do your commits - you want to avoid them unless they have a good reason to still be there.
There was a problem hiding this comment.
@lintsang this is all that's left and then I can mark as complete 🙂
Liam310
removed
the
Needs Review
lintsang
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I followed the readme.md and finished the 1-implement-and-rewrite-tests folder