Manchester| 26-SDC-Jun | Fithi Teklom | Sprint 3 | Implement-shell-tools - #613
Open
Fithi-Teklom wants to merge 8 commits into
Open
Manchester| 26-SDC-Jun | Fithi Teklom | Sprint 3 | Implement-shell-tools#613Fithi-Teklom wants to merge 8 commits into
Fithi-Teklom wants to merge 8 commits into
Conversation
Fithi-Teklom
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start but there is quite a bit of work still to do.
You've built your own argument handling system. Is your way of handling options/arguments always going to be the best? Is there a better way of doing this?
| } | ||
|
|
||
| if (mode === "onePerLine") { | ||
| items.forEach(item => console.log(item)); |
Contributor
There was a problem hiding this comment.
Do you need to use a complete anonymous function here?
| total.words += stats.words; | ||
| total.bytes += stats.bytes; | ||
|
|
||
| printResult(stats, file); |
Contributor
There was a problem hiding this comment.
When printing multiple files, is the output neatly formatted? Could it be improved?
LonMcGregor
added
Reviewed
Fithi-Teklom
added
Needs Review
LonMcGregor
reviewed
Aug 11, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Have you tested these changes before comitting? I get errors when I try to run the code
LonMcGregor
added
Reviewed
Fithi-Teklom
added
Needs Review
Contributor
|
OK. This looks good now. Apologies for the delayed review. I would recommend trying this again making use of an argument parsing library, as that can simplify code a lot, but this meets the requirements as is. |
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implement shell tools using js program that matches the listed commands.
Task ID: CYF-1150