London| 26-Jul-SDC | Shaghayegh far| Sprint 5 | Prep Exercises - #664
Open
shaghayeghfar wants to merge 1 commit into
Open
London| 26-Jul-SDC | Shaghayegh far| Sprint 5 | Prep Exercises#664shaghayeghfar wants to merge 1 commit into
shaghayeghfar wants to merge 1 commit into
Conversation
shaghayeghfar
added
Needs Review
LonMcGregor
reviewed
Sep 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work on these tasks,they're almost complete.Just a couple of small questions about some of them
Contributor
There was a problem hiding this comment.
Can you check this file with mypy? I get an error when I try to check it
| } | ||
|
|
||
| if preferred_operating_system not in available_operating_systems: | ||
| print( |
Contributor
There was a problem hiding this comment.
Is there a way you could improve the UX of submitting some of these inputs, like OS?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
I worked on the exercises in Sprint 5 , including the Python classes, dataclasses, generics, mypy, and inheritance exercises.
CYF-1155