London | 26-SDC-July | Kris Oldrini | Sprint 4 | Python Shell Tools - #665
Open
XiaoQuark wants to merge 4 commits into
Open
London | 26-SDC-July | Kris Oldrini | Sprint 4 | Python Shell Tools#665XiaoQuark wants to merge 4 commits into
XiaoQuark wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
XiaoQuark
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
XiaoQuark
added
the
Needs Review
LonMcGregor
reviewed
Sep 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work on these tasks, I have a question about one of them that indicates you could simplify the structure of the code.
| with open(path, "r") as file: | ||
| lines = file.readlines() | ||
|
|
||
| if args.number_nonblank: |
Contributor
There was a problem hiding this comment.
Given basically the same method call is used here, is there a reason for checking if args.number_nonblank here, then passing a parameter, then having another if; instead of checking this arg directly in the number_lines function?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented Python versions of the
cat,ls, andwccommand-line tools.catsupports-n/--numberand-b/--number-nonblank.lssupports-1/--formatand-a/--all, as well as files, directories, and multiple paths.wcsupports-l/--lines,-w/--words, and-c/--bytes, including multiple files and totals.