Manchester | 26-SDC-Jul | Fithi Teklom | Sprint 4 | Implement shell tools in Python - #672
Open
Fithi-Teklom wants to merge 2 commits into
Open
Conversation
Fithi-Teklom
added
the
Needs Review
LonMcGregor
reviewed
Sep 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start, but I have a comment about one of the files.
For all of them,have you considered using a library or package to help you with argument parsing?
|
|
||
| output = [] | ||
|
|
||
| if count_lines: |
Contributor
There was a problem hiding this comment.
it looks like there is some duplication in the structure of this code. Can you think of a way to simplify it?
LonMcGregor
added
Reviewed
This comment has been minimized.
This comment has been minimized.
Fithi-Teklom
added
Needs Review
LonMcGregor
reviewed
Sep 7, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good work, it's always worth looking for repeated code you can abstract into a function.
Could you answer the question in my earlier review please?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1152
Changelist
Implemented shell tools (wc, cat, ls) using python