Birmingham | July-SDC-26 | Merve Reis | Sprint 5 | Prep exercises - #684
Open
mervereis wants to merge 4 commits into
Open
Birmingham | July-SDC-26 | Merve Reis | Sprint 5 | Prep exercises #684mervereis wants to merge 4 commits into
mervereis wants to merge 4 commits into
Conversation
mervereis
added
the
Needs Review
mervereis
added
Needs Review
Khantdotcom
suggested changes
Sep 5, 2026
Khantdotcom
left a comment
Khantdotcom
left a comment
There was a problem hiding this comment.
Mandatory fix - Indentation errors.
| # Since the function is called double, it should multiply the number by 2. | ||
|
|
||
| def double(number): | ||
| return number * 2 |
There was a problem hiding this comment.
Indentation error. Read this article here to see how indentation in python works.
| self.address = address | ||
|
|
||
| imran = Person("Imran", 22, "Ubuntu", "Sheffield") | ||
| print(imran.address) |
There was a problem hiding this comment.
Indentation error. Read this article here to see how indentation in python works.
| if total_pence < 100: | ||
| return f"{total_pence}p" | ||
|
|
||
| pounds = int(total_pence / 100) |
There was a problem hiding this comment.
You might want to use python's floor division here without needing int conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
Replace this line with the Task code 1155
Did all the exercises.