Skip to content

chore: update Code Connect files for Molecules + DataList#3383

Open
LinKCoding wants to merge 7 commits into
mainfrom
kl-gmt-1552-codeconnect-molecukles-update
Open

chore: update Code Connect files for Molecules + DataList#3383
LinKCoding wants to merge 7 commits into
mainfrom
kl-gmt-1552-codeconnect-molecukles-update

Conversation

@LinKCoding

@LinKCoding LinKCoding commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Overview

Updates Gamut Figma Code Connect mappings for several molecules and organisms so Dev Mode snippets match the redesigned Figma components.

  • Modal (Modal.figma.tsx): single connect with figma.boolean('views', …) instead of variant restrictions; maps title, description, image, and multi-view CTAs.
  • Dialog (Dialog.figma.tsx): maps CTAs from nested Text Button / Fill Button layers via figma.nestedProps and figma.textContent; aligns title with Figma property.
  • Menu items (MenuItemFixed.figma.tsx, MenuItemPopover.figma.tsx): active and disabled as variants (TRUE/FALSE); leading-icon and ↳ label unchanged.
  • Pagination (Pagination.figma.tsx): fixes variant prop name and required totalPages / onChange in example.
  • Toast (Toast.figma.tsx): updated for new Figma Toast properties (title, description, anchor, icon).
  • DataTable (DataTableBasic.figma.tsx): points at component set 134718-26625; columns/rows aligned to header + content + control layout; typed ColumnConfig / idKey="header1".
  • TextButton (TextButton.figma.tsx): adds variants

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1552
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. on Figma, check the the following components: TextButton, Modal, Dialog, Menu (MenuItems), Pagination, Toast, DataTable and see that there's no errors in the CodeConnect code snippets (and that the props make sense)
  2. ...
  3. Finish and do a celebratory dance

PR Links and Envs

N/A

@nx-cloud

nx-cloud Bot commented Jun 23, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 9b1c188


☁️ Nx Cloud last updated this comment at 2026-06-25 14:09:16 UTC

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@LinKCoding LinKCoding force-pushed the kl-gmt-1552-codeconnect-molecukles-update branch from 9d61cf3 to 4699b5c Compare June 23, 2026 18:37
@LinKCoding LinKCoding marked this pull request as ready for review June 23, 2026 18:44
@LinKCoding LinKCoding requested a review from a team as a code owner June 23, 2026 18:44
@LinKCoding LinKCoding requested a review from speterson-cc June 23, 2026 18:44
Comment thread packages/code-connect/Atoms/Buttons/TextButton.figma.tsx
Comment thread packages/code-connect/Molecules/Modals/Modal.figma.tsx

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is it possible to include the bg wrapper? I guess if they stick with the default (background-current) they wouldn't need the bg wrapper, but is it possible to surface otherwise? I gave designers just 3 options for bg to ensure contrast.
  2. this might contradict what I said yesterday, but wondering if it would be useful to be able to copy the actual config values when they click on an individual column? I understand that we can't surface the actual values when they select DataTable, wondering if we could at least give them something that shows the actual ColumnConfig values.

@LinKCoding LinKCoding requested a review from speterson-cc June 24, 2026 19:37
@LinKCoding LinKCoding force-pushed the kl-gmt-1552-codeconnect-molecukles-update branch from 8bf9e78 to 9b1c188 Compare June 25, 2026 14:07
@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 72.2.2-alpha.a3d3a3.0 npm diff
@codecademy/gamut-icons 9.57.10-alpha.a3d3a3.0 npm diff
@codecademy/gamut-illustrations 0.58.16-alpha.a3d3a3.0 npm diff
@codecademy/gamut-kit 3.0.6-alpha.a3d3a3.0 npm diff
@codecademy/gamut-patterns 0.10.35-alpha.a3d3a3.0 npm diff
@codecademy/gamut-styles 20.0.3-alpha.a3d3a3.0 npm diff
@codecademy/gamut-tests 6.0.6-alpha.a3d3a3.0 npm diff
@codecademy/variance 0.26.2-alpha.a3d3a3.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.a3d3a3.0 npm diff

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants