Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Potentially related open or recent pull requests:
If one of these replaces this PR, a maintainer can close this with |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds deterministic integration tests that exercise
Anchor.ingest_filewith the existing text and Markdown fixtures and document extractor metadata that is currently dropped before storage. The strict xfails are limited to known missing metadata fields so unrelated crashes, wrong values, and partially missing offsets still fail normally.Linked context
Closes #77
Supersedes #101
Related to #68
This PR consolidates my earlier overlapping PR #101. It is distinct from #68, which merged the Markdown extractor implementation and dependency changes; this PR changes only
tests/integration/test_ingestion_pipeline.pyand adds no extractor, API, dependency, fixture, prompt, or production-code changes.PR Size
PR Type
promptlabel required; eval results required below)Context / Motivation
Extractor unit tests alone do not cover the public file-ingestion path into storage. The previous integration coverage called
Ingestordirectly, so it could not detect metadata dropped between extractor output andMemoryStore.add. Issue #77 asks for pipeline-level proof using offline text and Markdown fixtures, with xfails where existing fields are currently lost.Changes
.txtand.mdfixtures through the realAnchor.ingest_filepath using an offline deterministic model andFakeMemoryStore.source_format, character offsets, line offsets, and Markdown heading metadata.source_format, text offsets, Markdownsource_format, and Markdown heading.MissingDocumentMetadataso wrong present values, partially missing offsets, and unrelated crashes remain ordinary failures.No production code, public API, fixture, dependency, prompt, or model changes are included.
How to test
Current re-verification at PR head
8e4859f151a0572fbcd4d4d72b5c97259f0f8421, using the existing Anchor virtual-environment Python on Windows:python -m pytest tests/integration/test_ingestion_pipeline.py -q -rxXResult:
I did not re-run the repository-wide pytest suite, Ruff, Mypy, pre-commit, or dependency audit for this body update, so this body does not claim current repo-wide green checks.
Prompt Change Eval Results
Not applicable: this PR changes no prompts and introduces no model calls.
Checklist
Notes for reviewers
These tests document current metadata loss; they do not repair ingestion. Strict xfails become suite-failing XPASS results when the corresponding fields begin reaching storage with the expected values. Incorrect present values, partially missing offsets, and unrelated failures remain ordinary failures.
AI assistance disclosure: Codex assisted with drafting, refining, and verifying this test-only change. The final body was prepared from live PR/template/workflow reads and a fresh narrow test run before submission.