Repository navigation
fix(ci): warn instead of fail when a documented bound is narrower than the provider's - #1942
Merged
Merged
Conversation
…n the provider's BFL raised safety_tolerance's maximum to 7 in its published spec; Router still validates 4, so the documented 4 is correct. The provider-schemas check treated any bound mismatch as an error, turning every router-docs PR red. Only a bound WIDER than the provider's now fails; a narrower one warns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Since ~19:14 UTC on 2026-10-12, every PR that touches Router docs has failed the Code Pages Freshness / provider-schemas check (for example #1941). The cause isn't in those PRs. BFL changed its published API spec so
safety_tolerancenow goes up to 7. Our FLUX 3 Video and FLUX Video Upscale pages say 4, because 4 is the limit Comfy Router actually enforces (the Router schema in cloud). The checker required the two numbers to match exactly, so a limit we tightened on purpose counted as an error.Change
check-provider-schemas.ts, a documentedminimum/maximumthat is wider than the provider's is still an error, because it advertises values the provider rejects.Verification
bun test ./.github/scripts/snippets/: 120 pass, 0 failbun run code-pages:check-providersagainst live provider specs: 0 errors (was 2). The twosafety_tolerancemismatches now appear as warnings.Follow-up (not in this PR)
Whether Router should accept
safety_toleranceup to 7 is a separate product/moderation decision on the cloud side. If it changes, the generated docs will pick it up through the normal spec sync.Provenance
Investigated and written with Claude Code after a Slack report from Lin that CI was failing across many PRs.
🤖 Generated with Claude Code