Add cap to backlog entries#492
Open
PringlesGang wants to merge 6 commits into
Open
Conversation
PringlesGang
force-pushed
the
backlog-entry-cap
branch
from
f927da6 to
cd16026
Compare
…ment nullptr checks
If you have the scrollbar in a random position and then load a save (clearing the backlog), the scrollbar progress would not update until the show animation had finshed, showing the wrong progress during the show animation
PringlesGang
force-pushed
the
backlog-entry-cap
branch
from
cd16026 to
a8a255a
Compare
KKhanhH
requested changes
Jul 10, 2026
Collaborator
There was a problem hiding this comment.
Instead of circular buffer of unique_ptrs of backlog entries (of which there is only one type tied to the game, so the polymorphism support isn't needed), could we have a circular buffer of concrete classes instead? for 400 entries I could imagine this might add some performance hit to it. If we wanna avoid code duplication we could maybe do a CRTP type class where backlog entry type is one of the template args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores the backlog entries in a circular buffer and adds a maximum number of entries to the profile. When full, the oldest entry will be overwritten by the new entry.
The maximum is profile-configurable and defaulted to 400, as per the MAGES. engine.
Scrollbar*to simply aScrollbar