fix(gate-55): port the OBJECT route form fix — the package was behind hydra - #137
Merged
Conversation
… hydra
Second casualty of the same drift that cost gates 62/63. hydra's
`development` carries `a48e65e2 fix(gate-55): catch the OBJECT route form, not
just string route values`, and the package's copy of
`check_detail_page_discipline.py` predates it by 25 lines.
The fix catches `"route": {"name": "<pageId>", "query": {...}}` — the object form
stats-block entries use to deep-link a KPI. The renderer calls
`router.resolve({name, query})` inside a computed and reads `.href` off the
result, so an unresolvable name throws and the page emits console errors. A gate
that only inspected string route values never saw it.
Found while resolving hydra#512's merge: the file is deleted in the delegation
branch and modified on development, so taking either side silently loses
something. That is now twice in one merge — the exact drift the delegation exists
to end, appearing while the delegation is still in flight.
⚠️ Worth stating plainly: my first attempt at this port wrote an EMPTY file,
because I ran `git show origin/development:…` inside the .github clone, where
that ref does not exist — it is hydra's. `git show` on a missing ref produced
nothing, the redirect truncated the file, and the diff read "453 deletions".
An absence manufactured by a wrong lookup, caught only because 453 deletions is
an implausible shape for a one-commit port. The diff is now +25/-0, which is
what a port of a 25-line fix should look like.
py_compile clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second casualty of the same drift that cost gates 62/63.
hydra's
developmentcarriesa48e65e2 fix(gate-55): catch the OBJECT route form, not just string route values; the package'scheck_detail_page_discipline.pypredates it by 25 lines.The fix catches
"route": {"name": "<pageId>", "query": {...}}— the object form stats-block entries use to deep-link a KPI. The renderer callsrouter.resolve({name, query})in a computed and reads.href, so an unresolvable name throws and the page emits console errors. A gate inspecting only string route values never saw it.Found resolving hydra#512: the file is deleted in the delegation branch and modified on development, so either mechanical resolution loses something. That is twice in one merge — the exact drift the delegation exists to end, appearing while the delegation is still in flight.
git show origin/development:…inside the.githubclone, where that ref doesn't exist (it's hydra's).git showon a missing ref produced nothing, the redirect truncated the file, and the diff read 453 deletions. An absence manufactured by a wrong lookup, caught only because 453 deletions is an implausible shape for a one-commit port. The diff is now +25/-0.Unblocks hydra#512 → openbuild#104.