ci: rename branch-protection caller job id to branch-protection - #115
Open
rubenvdlinde wants to merge 1 commit into
Open
ci: rename branch-protection caller job id to branch-protection#115rubenvdlinde wants to merge 1 commit into
branch-protection#115rubenvdlinde wants to merge 1 commit into
Conversation
…ion` GitHub names a reusable-workflow status context `<caller-job-id> / <called-job-name>`, so this caller reported as `check / check-branch` while the org ruleset requires `branch-protection / check-branch`. Also repoints the reusable workflow from `Conduction/.github` to `ConductionNL/.github`. The `Conduction` org does not exist (404), so on this branch the workflow could not resolve at all — a second, independent reason the required context never reported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub names a reusable-workflow status context
<caller-job-id> / <called-job-name>.This branch's caller job id was not
branch-protection, so the shared branch-protectionworkflow reported under the wrong context name, and the org ruleset requirement
branch-protection / check-branchnever reported at all — not as a failure, as nothing.Several of these beta branches carry a second, independent fault: the reusable workflow was
referenced as
Conduction/.githubinstead ofConductionNL/.github. TheConductionorg does notexist (
GET /repos/Conduction/.github-> 404), so on those branches the workflow could not evenresolve. Where present, that is fixed here too — renaming the job id alone would not have made the
context appear.
This matters for
beta -> mainpromotion PRs, whose head isbeta, so beta's tip is whatdecides the context name and the workflow reference.
Does not change what is required and does not touch any ruleset or branch protection.