Update deprecated ghcr.io image reference to public.ecr.aws - #32
Update deprecated ghcr.io image reference to public.ecr.aws#32luisina-santos wants to merge 1 commit into
Conversation
README.md referenced this connector's image via ghcr.io/conductorone; container images are now published to public.ecr.aws/conductorone instead. Only this connector's own image reference was updated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
||
| ``` | ||
| docker run --rm -v $(pwd):/out -e BATON_SECRET_KEY=secretKey BATON_INTEGRATION_KEY=integrationKey BATON_API_HOSTNAME=apiHostname ghcr.io/conductorone/baton-duo:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out -e BATON_SECRET_KEY=secretKey BATON_INTEGRATION_KEY=integrationKey BATON_API_HOSTNAME=apiHostname public.ecr.aws/conductorone/baton-duo:latest -f "/out/sync.c1z" |
There was a problem hiding this comment.
🟡 Suggestion: This documented command doesn't work as written (pre-existing, but on the line you touched). Only BATON_SECRET_KEY has an -e; Docker treats the next positional arg, BATON_INTEGRATION_KEY=integrationKey, as the image name, so the run fails before reaching public.ecr.aws/.... Each variable needs its own -e.
| docker run --rm -v $(pwd):/out -e BATON_SECRET_KEY=secretKey BATON_INTEGRATION_KEY=integrationKey BATON_API_HOSTNAME=apiHostname public.ecr.aws/conductorone/baton-duo:latest -f "/out/sync.c1z" | |
| docker run --rm -v $(pwd):/out -e BATON_SECRET_KEY=secretKey -e BATON_INTEGRATION_KEY=integrationKey -e BATON_API_HOSTNAME=apiHostname public.ecr.aws/conductorone/baton-duo:latest -f "/out/sync.c1z" |
| ``` | ||
| docker run --rm -v $(pwd):/out -e BATON_SECRET_KEY=secretKey BATON_INTEGRATION_KEY=integrationKey BATON_API_HOSTNAME=apiHostname ghcr.io/conductorone/baton-duo:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out -e BATON_SECRET_KEY=secretKey BATON_INTEGRATION_KEY=integrationKey BATON_API_HOSTNAME=apiHostname public.ecr.aws/conductorone/baton-duo:latest -f "/out/sync.c1z" | ||
| docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources |
There was a problem hiding this comment.
🟡 Suggestion (low confidence): The next line still uses ghcr.io/conductorone/baton:latest. The PR description intentionally scopes this to the connector's own image, and that's the baton CLI from a different repo — but if the ghcr.io deprecation is org-wide, this reference is stale too and sits two lines from the one you fixed. Worth confirming whether the baton CLI image is also published to public.ecr.aws/conductorone/baton.
Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.awsBlocking Issues: 0 | Suggestions: 2 | Threads Resolved: 0 Review SummaryScanned the full PR diff for security and correctness: it is a single-line documentation change swapping this connector's docker image registry from Security IssuesNone found. Correctness IssuesNone found. Suggestions
Prompt for AI agents |
Summary
ghcr.io/conductorone/baton-duo:latest; container images are now published topublic.ecr.aws/conductorone/baton-duo:latestinstead.Test plan
public.ecr.aws/conductorone/baton-duo:latestresolves (manifest exists) before opening this PR.🤖 Generated with Claude Code