Skip to content

Remove superseded Cone release configuration - #151

Open
c1-squire-dev[bot] wants to merge 1 commit into
mainfrom
paul/remove-local-release-configs
Open

Remove superseded Cone release configuration#151
c1-squire-dev[bot] wants to merge 1 commit into
mainfrom
paul/remove-local-release-configs

Conversation

@c1-squire-dev

@c1-squire-dev c1-squire-dev Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Scope

Remove repository-local release configuration that baton-admin has replaced with the verified shared release caller.

Removed

  • Local GoReleaser binary and Docker configurations
  • Legacy Gon macOS signing configurations

Preserved

The baton-admin-managed .github/workflows/release.yaml remains the sole release entrypoint.

Verification

  • go test ./...

Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

General PR Review: Remove superseded Cone release configuration

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: none loaded - .claude/skills/ci-review.md was not found at trusted base 52626a25f504.
Review mode: full
View review run

Review Summary

Scanned the full PR diff for security and correctness: this change is deletion-only (182 lines across .goreleaser.yaml, .goreleaser.docker.yaml, .gon-amd64.json, .gon-arm64.json) with no Go source, go.mod, or go.sum changes. I verified the removal is safe: .github/workflows/release.yaml already existed at the base SHA and delegates to ConductorOne/github-workflows/.github/workflows/release.yaml@v4, which generates its own GoReleaser and gon configs from templates into _workflows/_generated/ and never reads caller-repo config files; ci.yaml, main.yaml, and the Makefile contain no references to the deleted paths. Removing the Gon files also drops a hardcoded Apple ID and Developer ID team identifier from the tree, which is a small net improvement.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • Dockerfile:1 — the repo-local Dockerfile is now dead config as well: the shared release workflow only uses a caller Dockerfile when dockerfile_template is set, and .github/workflows/release.yaml does not set it, so the workflow renders its own default template instead. The shared workflow README's onboarding step 3 says to remove GoReleaser, gon, and Dockerfile/Dockerfile.lambda files. Confidence: medium — harmless if intentionally kept for local docker build, but it is misleading to leave a Dockerfile that no longer produces the released image.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `Dockerfile`:
- Around line 1-3: This Dockerfile is no longer used to build released images. The
  release entrypoint `.github/workflows/release.yaml` calls
  ConductorOne/github-workflows release.yaml@v4 with `docker: true` but without a
  `dockerfile_template` input, so the shared workflow generates its own Dockerfile
  from `templates/.Dockerfile-template.tmpl` into `_workflows/_generated/Dockerfile`.
  Either delete this file as part of the same cleanup that removed the GoReleaser and
  gon configs, or, if the repo intends to keep controlling the image base, wire it up
  by adding `dockerfile_template: Dockerfile` to the `with:` block in
  `.github/workflows/release.yaml`. If it is deliberately kept only for local
  `docker build`, add a comment at the top saying so.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant