Skip to content

Fix(frontend): remove autocomplete prop spread, keep autocomplete props off input DOM node - #255

Merged
KelvinTegelaar merged 1 commit into
CyberDrain:devfrom
k-grube:fix/autocomplete-dom-prop-leak
Aug 15, 2026
Merged

Fix(frontend): remove autocomplete prop spread, keep autocomplete props off input DOM node#255
KelvinTegelaar merged 1 commit into
CyberDrain:devfrom
k-grube:fix/autocomplete-dom-prop-leak

Conversation

@k-grube

@k-grube k-grube commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

prop spread on CippAutocomplete is passing props down to the input DOM node and triggering an error

installHook.js:1 React does not recognize the `filterSelectedOptions` prop on a DOM element. 
If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `filterselectedoptions` instead. 
If you accidentally passed it from a parent component, remove it from the DOM element.
overrideMethod	@	installHook.js:1
<ForwardRef(TextField)>		
MemoTextField	@	CippAutocomplete.jsx:41
<MemoTextField>		
...

fix:
remove prop spread and the denylist so that when future props are passed, the denylist doesn't have to keep increasing
add variant prop for consumers that are utilizing this through to text field components
add relevant tests

@k-grube k-grube changed the title Fix(frontend): remove autocomplete prop spread, keep autocomplete pro… Fix(frontend): remove autocomplete prop spread, keep autocomplete props off input DOM node Aug 11, 2026
@KelvinTegelaar
KelvinTegelaar merged commit c80ac4f into CyberDrain:dev Aug 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants