fix(net-filter): use rule id as map key in update_rule - #138
Merged
Conversation
update_rule() was writing to &key_cnt instead of the caller-provided rule id, so updating a rule silently modified the wrong map entry (or failed with BPF_EXIST when that slot did not exist). Use &key so the operation targets the rule id given by the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135
NetFilter::update_rule()
ignored the caller-providedrule_idand wrote to&key_cntinstead, so updating a rule silently modified the wrong map entry (or failed withBPF_EXISTwhen that slot did not exist). Use&key` so the operation targets the requested rule id.