fix(dkapture): return bytes read, not remaining buffer size, in vector read()s - #140
Open
JoeSergen wants to merge 1 commit into
Open
fix(dkapture): return bytes read, not remaining buffer size, in vector read()s#140JoeSergen wants to merge 1 commit into
JoeSergen wants to merge 1 commit into
Conversation
…r read()s
The two buffer-based overloads read(std::vector<DataType>&, pid, buf,
bsz) and read(std::vector<const char*>&, buf, bsz) returned the
leftover bsz after the loop instead of the number of bytes written,
contradicting the documented contract ('success returns the number of
bytes read'). Accumulate total bytes written and return that, matching
the read(DataType, std::vector<pid_t>&, ...) overload.
Contributor
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
The two buffer-based overloads
read(std::vector<DataType>&, pid, buf, bsz)andread(std::vector<const char*>&, buf, bsz)returned the leftoverbszafter the loop instead of the number of bytes written, contradicting the documented contract. Accumulate the total bytes written and return that, matchingread(DataType, std::vector<pid_t>&, ...).