fix(dkapture): honor parsed pid in read(vector<path>, cb) callback mode - #141
Open
JoeSergen wants to merge 1 commit into
Open
fix(dkapture): honor parsed pid in read(vector<path>, cb) callback mode#141JoeSergen wants to merge 1 commit into
JoeSergen wants to merge 1 commit into
Conversation
The overload read(std::vector<const char*>&, DKCallback, void*) parsed the pid out of each /proc/<pid>/<node> path but then ignored it and called read(dt, cb, ctx), which iterates ALL processes. Read the specific process' data via the buffer API and invoke the callback once per DataHdr record, so /proc/1234/stat only reports pid 1234. Guard against zero/oversized dsz to avoid an infinite loop on bad records.
Contributor
|
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134
ead(std::vector<const char*>&, DKCallback, void*)
parsed the pid out of each/proc//path but then ignored it and calledread(dt, cb, ctx), which iterates ALL processes. Read the specific process' data via the buffer API and invoke the callback once perDataHdrrecord, so/proc/1234/statonly reports pid 1234. Guards against zero/oversizeddsz` to avoid an infinite loop on bad records.