Extend July release - #138
Merged
Merged
Conversation
Collaborator
|
Is this ready from your side @benegee? I am currently planning some similar updates to P4est.jl and also noticed that updating Clang.jl to v0.19 changed a lot of lines in LibP4est.jl (not sure if it also added new bindings). It would be nice if you could also take a look there and help with your experience from T8code.jl. |
Collaborator
Author
|
Thanks @JoshuaLampert! About P4est,jl, I'd be happy to help! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Claude's help I was finally able to systematically investigate the increased number of bindings seen in #135. The reason is of course very stupid. When I decided to upgrade Clang.jl, I started the dev project from scratch and Glob.jl was updated as well. Glob.jl version 1.5.0 added a lot of features, among them vtjnash/Glob.jl#58 which added support for
**in paths. With this feature,T8code.jl/dev/generator.jl
Line 24 in 7cc9233
libt8.soanyway.This PR therefore is an extension of the previous July release. It adds the deeply nested headers, which were excluded before.
Some comments:
t8_refcount.h, which is shipped erroneously in aPRIVATE_HEADERfolder, see t8code July release #127 (comment).t8_dtri_to_dtet.h, which is one of the new headers. It redefines several API functions, which actually exist in libt8.so and are usable, see Update to Clang 0.19 #135const P4EST_QMAXLEVEL = 29which is defined in some p4est header, see Update to Clang 0.19 #135dev/Manifest.tomlto the repo to better track how released were generated.Finally I asked Claude to compare
Libt8.jlin this PR with current main's:(
t8_mat_*comes from another header file inPRIVATE_HEADER. I had copied it manually before, which however does not make sense)Based on this analysis, this could be a non-breaking release.
Next steps would the actual upgrade of Clang.jl (#135) and new monthly releases.