Feature: Added Element Methods (get_reference_coordinates, element_is_equal, t8_forest_leaf_face_orientation) - #2360
Feature: Added Element Methods (get_reference_coordinates, element_is_equal, t8_forest_leaf_face_orientation)#2360Vyp3er wants to merge 17 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
+ Coverage 82.28% 82.37% +0.09%
==========================================
Files 125 125
Lines 20701 20718 +17
==========================================
+ Hits 17033 17066 +33
+ Misses 3668 3652 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: lenaploetzke <70579874+lenaploetzke@users.noreply.github.com>
|
Please clean up the PR and remove changes in files that are not relevant here :) |
lenaploetzke
left a comment
There was a problem hiding this comment.
Very cool addition, thank you :)
| * \return The orientation of the face with respect to its neighbor. Returns 0 if the face has no neighbor. | ||
| */ | ||
| int | ||
| get_face_orientation (int face) const |
There was a problem hiding this comment.
Very cool function, could you maybe use this one in dg_competences.hxx?
| * reference space of the tree. | ||
| * \param [in] ref_coords Pointer to the reference coordinates of the element. | ||
| * \param [in] num_coords Number of reference coordinates to convert. | ||
| * \param [out] tree_ref_coords Pointer to the reference coordinates of the tree. |
There was a problem hiding this comment.
Eigentlich ist das ein bisschen missverständlich mit dem tree weils ja hier gar keine trees gibt. Vllt schreibst du tree/cmesh element?
| return m_is_ghost_element; | ||
| } | ||
|
|
||
| /** Check if two elements are equal. |
There was a problem hiding this comment.
Check if the element is equal to an other element. ist glaube ich besser
Describe your changes here:
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
scripts/internal/find_all_source_files.shto check the indentation of these files.License
doc/(or already has one).