Skip to content

feat: record ENSv2 mainnet deployment - #5

Merged
JOY (JOY) merged 1 commit into
dosfrom
codex/ensv2-mainnet-manifest
Aug 12, 2026
Merged

feat: record ENSv2 mainnet deployment#5
JOY (JOY) merged 1 commit into
dosfrom
codex/ensv2-mainnet-manifest

Conversation

@JOY

Copy link
Copy Markdown

Summary

  • record the canonical DOS Mainnet ENSv2 deployment at blocks 117 through 162
  • render the custom BENS subgraph for either canonical DOS Testnet or Mainnet
  • build both canonical manifests in CI

On-chain evidence

  • chain ID: 7979
  • deployment transactions: 46
  • independently verified successful receipts: 46/46
  • first transaction: 0xb2fc1d57f72439403e095a8ec1d319342069cf400d77c89b5a043d43eb301ffc
  • last transaction: 0xd1860882db7b632405c6189b4dbad6804f37fc6b957e0558e13d37738170ccbb
  • deployer root roles: zero on all six handed-off contracts
  • forward and reverse smoke resolution: bens-smoke.dos

Validation

  • renderer tests: 9/9 passed
  • canonical Testnet render, codegen, and build passed
  • canonical Mainnet render and build passed
  • local Matchstick remains unavailable on Windows; the preceding reviewed mapping head passed 30/30 and this PR does not change mappings

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the DOS Mainnet (chainId 7979) to the subgraph deployment. It introduces the mainnet deployment configuration, updates package scripts, and modifies the manifest rendering script to dynamically replace the network name in the template. The review feedback suggests simplifying the script by removing the redundant EXPECTED_CHAIN_IDS set and dynamically generating the error message for unsupported chain IDs using the keys of the NETWORKS map.

Comment on lines +5 to +9
const EXPECTED_CHAIN_IDS = new Set([3939, 7979]);
const NETWORKS = new Map([
[3939, "dos-testnet"],
[7979, "dos-mainnet"],
]);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Maintaining both EXPECTED_CHAIN_IDS and NETWORKS is redundant and can lead to out-of-sync configurations when adding new networks. We can simplify this by using only the NETWORKS map and checking its keys.

const NETWORKS = new Map([
  [3939, "dos-testnet"],
  [7979, "dos-mainnet"],
]);

Comment on lines +23 to 25
if (!EXPECTED_CHAIN_IDS.has(deployment?.chainId)) {
throw new Error("chainId must be one of 3939, 7979");
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of checking EXPECTED_CHAIN_IDS, we can check NETWORKS.has(...). Additionally, we can dynamically construct the error message using the keys of NETWORKS to prevent the error message from becoming out of sync when new networks are added.

Suggested change
if (!EXPECTED_CHAIN_IDS.has(deployment?.chainId)) {
throw new Error("chainId must be one of 3939, 7979");
}
if (!NETWORKS.has(deployment?.chainId)) {
throw new Error("chainId must be one of " + Array.from(NETWORKS.keys()).join(", "));
}

@JOY
JOY (JOY) merged commit 6224395 into dos Aug 12, 2026
19 of 21 checks passed
@JOY
JOY (JOY) deleted the codex/ensv2-mainnet-manifest branch August 12, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant