Add safe area to WDOS token icon - #3
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the viewBox of the WDOS.svg icon to add padding and introduces a unit test to verify that the icon has a safe area for circular cropping. The reviewer suggested using the exact original dimensions of the artwork (5808.5 and 5808.4) in the test instead of the rounded 5808.6 to ensure accuracy.
| for value in ET.parse(icon_path).getroot().attrib["viewBox"].split() | ||
| ) | ||
| view_x, view_y, view_width, view_height = view_box | ||
| artwork_x, artwork_y, artwork_width, artwork_height = (0.0, 0.0, 5808.6, 5808.6) |
There was a problem hiding this comment.
The original viewBox of the WDOS icon was 0 0 5808.5 5808.4. Hardcoding the artwork dimensions as (0.0, 0.0, 5808.6, 5808.6) in the test introduces a slight discrepancy from the actual original dimensions. Using the actual original dimensions 5808.5 and 5808.4 is more accurate and still passes the assertion of padding_ratio >= 0.095.
Suggested change
| artwork_x, artwork_y, artwork_width, artwork_height = (0.0, 0.0, 5808.6, 5808.6) | |
| artwork_x, artwork_y, artwork_width, artwork_height = (0.0, 0.0, 5808.5, 5808.4) |
JOY (JOY)
force-pushed
the
codex/wdos-icon-padding
branch
from
August 13, 2026 00:08
3ef1bee to
cf6fae7
Compare
JOY (JOY)
force-pushed
the
codex/wdos-icon-padding
branch
from
August 13, 2026 00:12
cf6fae7 to
f4b1ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
n- python -B tools/token-list-validator/validate_assets.py configs/token-lists/mainnet.jsonn- yarn eslint --config .eslintrc.cjs --resolve-plugins-relative-to . .`n- all config validators