Fix: _WD_UpdateDriver resolving wrong browser row - #552
Open
Danp2 wants to merge 1 commit into
Open
Conversation
…icit $iIndex was read from @Extended, which is only set correctly by the preceding _WD_GetBrowserVersion() call. That call is skipped whenever the caller passes an explicit $sBrowserVersion (the documented offline-update use case), leaving $iIndex holding a stale value from an unrelated StringRegExpReplace() call earlier in the function. This could point $sDriverEXE at the wrong browser's driver entirely. Now $iIndex is resolved directly from $sBrowser in that branch, mirroring the same name-matching fallback _WD_GetBrowserVersion() uses internally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Proposed changes
$iIndex was read from @Extended, which is only set correctly by the preceding _WD_GetBrowserVersion() call.
That call is skipped whenever the caller passes an explicit $sBrowserVersion (the documented offline-update use case), leaving $iIndex holding a stale value from an unrelated StringRegExpReplace() call earlier in the function.
This could point $sDriverEXE at the wrong browser's driver entirely. Now $iIndex is resolved directly from $sBrowser in that branch, mirroring the same name-matching fallback _WD_GetBrowserVersion() uses internally.
Checklist
Put an
xin the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!This is simply a reminder of what we are going to look for before merging your code.
Types of changes
Please check
xthe type of change your PR introduces:What is the current behavior?
Please describe the current behavior that you are modifying, or link to a relevant issue.
What is the new behavior?
Please describe the behavior or changes that are being added by this PR.
Influences and relationship to other functionality
Describe how the changes will affect other functions, potential script breaking changes, etc.
Additional context
Add any other context about the problem here.
System under test
Please complete the following information.