Skip to content

Fix: _WD_UpdateDriver resolving wrong browser row - #552

Open
Danp2 wants to merge 1 commit into
masterfrom
fix/updatedriver-stale-extended-index
Open

Fix: _WD_UpdateDriver resolving wrong browser row #552
Danp2 wants to merge 1 commit into
masterfrom
fix/updatedriver-stale-extended-index

Conversation

@Danp2

@Danp2 Danp2 commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Pull request

Proposed changes

$iIndex was read from @Extended, which is only set correctly by the preceding _WD_GetBrowserVersion() call.

That call is skipped whenever the caller passes an explicit $sBrowserVersion (the documented offline-update use case), leaving $iIndex holding a stale value from an unrelated StringRegExpReplace() call earlier in the function.

This could point $sDriverEXE at the wrong browser's driver entirely. Now $iIndex is resolved directly from $sBrowser in that branch, mirroring the same name-matching fallback _WD_GetBrowserVersion() uses internally.

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!

This is simply a reminder of what we are going to look for before merging your code.

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

What is the new behavior?

Please describe the behavior or changes that are being added by this PR.

Influences and relationship to other functionality

Describe how the changes will affect other functions, potential script breaking changes, etc.

Additional context

Add any other context about the problem here.

System under test

Please complete the following information.

  • OS: [e.g. Windows 10]
  • OS Arch.: [e.g. X64]
  • Browser [e.g. firefox]
  • Browser version [e.g. 96.0.3]

…icit

$iIndex was read from @Extended, which is only set correctly by the
preceding _WD_GetBrowserVersion() call. That call is skipped whenever
the caller passes an explicit $sBrowserVersion (the documented
offline-update use case), leaving $iIndex holding a stale value from
an unrelated StringRegExpReplace() call earlier in the function. This
could point $sDriverEXE at the wrong browser's driver entirely. Now
$iIndex is resolved directly from $sBrowser in that branch, mirroring
the same name-matching fallback _WD_GetBrowserVersion() uses
internally.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant