Skip to content

[CCR-3653] Split Cost Optimization Automation and Notification docs - #38993

Open
zeinageb wants to merge 12 commits into
masterfrom
zeina.gebran/ccr-3653-remediation-notification-docs
Open

[CCR-3653] Split Cost Optimization Automation and Notification docs#38993
zeinageb wants to merge 12 commits into
masterfrom
zeina.gebran/ccr-3653-remediation-notification-docs

Conversation

@zeinageb

@zeinageb zeinageb commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

  • Splits notification rule documentation into a new page, Automated Notifications, separate from the Cost Optimization Automation page, to mirror the Remediation and Notification tabs in the Automations UI.
  • Updates the Cost Optimization Automation page's supported recommendation types (multi-cloud coverage), prerequisites, and setup steps to match the current UI.
  • Adds a nav entry for the new page and cross-links between the two pages and the Recommendations overview page.

Merge readiness

  • Ready for merge

For Datadog employees:

  • ⚠️ Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR.
  • 🤖 New: Comment with /review to run an automated check that catches common issues before a Documentation team member reviews your PR.

AI assistance

Drafted with Claude Code, based on the current merged Automations UI behavior (Remediation and Notification tabs).

Additional notes

…tomation docs

Splits notification rules into their own page (automated_notifications.md),
matching the Notification/Remediation tabs in the Automations UI, and updates
the Cost Optimization Automation page with the current recommendation type
coverage, prerequisites, and setup steps.
@github-actions github-actions Bot added the Architecture Everything related to the Doc backend label Aug 7, 2026
@zeinageb

zeinageb commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review by Claude. AI-generated; verify before acting.

Two small suggestions inline. One additional note that isn't inline-commentable: the cost_optimization_automation.md page title was renamed to the plural (Cost Optimization Automations), but the sidebar menu entry at hugo/config/_default/menus/main.en.yaml:4225 still reads - name: Cost Optimization Automation (singular). Consider updating the menu name to match the new page title so the sidebar link matches the page's H1 and the reference on the _index.md overview.

Reviewed f0853a930b1c44a9e816663b7041bcc2c55913e1workflow run

Comment thread hugo/content/en/cloud_cost_management/recommendations/automated_notifications.md Outdated
Comment thread hugo/content/en/cloud_cost_management/recommendations/_index.md Outdated
@zeinageb
zeinageb marked this pull request as ready for review August 7, 2026 13:15
@zeinageb
zeinageb requested review from a team as code owners August 7, 2026 13:15
@jhgilbert jhgilbert added the astro-reorg-no-conflicts Needs manual conflict resolution after replatforming reorg label Aug 7, 2026
Points the mako template load at hugo/local/bin/py/, and updates the
content/en/ path matching to also accept the hugo/ prefix so preview
links resolve for files under the post-reorg layout.
@zeinageb
zeinageb requested a review from a team as a code owner August 7, 2026 14:07
Renames automated_notifications.md to notifications.md, since the page
hasn't shipped yet and there's no live URL to preserve.

@OliviaShoup OliviaShoup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for the PR! It looks really good. I've left some suggestions inline.

One note on scope: hugo/local/bin/py/preview_links.py is a build-script path fix unrelated to CCR-3653, so I haven't reviewed it. webops-platform is already a requested reviewer. Just flagging that this PR now spans two review domains and merging waits on both

Please let me know if you have any questions!

Comment thread hugo/content/en/cloud_cost_management/recommendations/notifications.md Outdated
Comment thread hugo/content/en/cloud_cost_management/recommendations/notifications.md Outdated
…ication prerequisites

Normalize the safeguards table to consistent phrasing, fix the EBS
snapshot optional/unconditional contradiction, restore the S3
Intelligent-Tiering reversibility fact alongside the preserved-rules
fact, remove a duplicated safeguards sentence, switch remaining bold
UI references to the ui shortcode, and add the required permission to
the Notifications prerequisites.
@zeinageb
zeinageb removed the request for review from a team August 11, 2026 08:36
Address Olivia's review comment: open the Overview with the page's own
term and mention the UI tab once, then use plain "Automations" for the
rest of the comparisons for consistency.
…n-notification-docs' into zeina.gebran/ccr-3653-remediation-notification-docs
@zeinageb
zeinageb requested a review from OliviaShoup August 11, 2026 08:48
The Cost Optimization Automation CRUD is backed by real Workflow
Automation objects and is gated by the Workflows Write permission,
not Cloud Cost Management Write.
Access to the Automations page requires Cloud Cost Management Write
at the route level; creating or editing an automation additionally
requires Workflows Write at the component level. These are two
separate, both-required permissions, not either/or.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend astro-reorg-no-conflicts Needs manual conflict resolution after replatforming reorg

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants