chore: moving to workspace-level dependencies, phase 2 - #2270
Conversation
github-actions
Bot
added
telemetry
mini-agent
sidecar
common
data-pipeline
crashtracker
sampling
labels
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: fbb2632 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksComparisonBenchmark execution time: 2026-07-27 15:43:19 Comparing candidate commit fbb2632 in PR branch Found 5 performance improvements and 22 performance regressions! Performance is the same for 150 metrics, 10 unstable metrics.
|
2ba3535 to
01f0e3a
Compare
yannham
changed the title
08e7e23 to
d13ce49
Compare
![datadog-official[bot]](https://avatars.githubusercontent.com/in/1358509?s=60&v=4){kind=small}
There was a problem hiding this comment.
The workspace-level serde_json declaration disables default features, but 15 migrated leaf dependencies inherit no replacement feature; production crates such as libdd-agent-client, libdd-telemetry, and libdd-sampling use allocation-gated JSON APIs. Their standalone builds therefore fail instead of producing the libraries consumed by downstream SDKs. No additional tests recommended: this is a manifest feature-resolution failure, not a runtime input class.
📊 Validated against 1 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit d13ce49 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
d13ce49 to
0db03dd
Compare
0db03dd to
0bf433a
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d13ce491c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0bf433a to
525ea94
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
e73b806 to
04c4c8a
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67f7856269
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… (phase 2) Add build_common, prost-build, protoc-bin-vendored, and serde_json to [workspace.dependencies] and migrate all leaf crates to workspace = true. - build_common: 15 FFI/build crates (all -ffi crates + builder) - prost-build, protoc-bin-vendored: libdd-ddsketch, libdd-trace-protobuf - serde_json: 22 crates (unifies pinned versions 1.0.117/1.0.127/1.0.132) All workspace deps declare default-features = false per the new policy. Each leaf crate that previously relied on implicit defaults now explicitly opts into the minimum required feature set: - 14 crates work with no features at all (serde_json not in their direct compile path or uses only alloc-compatible APIs transitively) - 4 crates (libdd-profiling-ffi, libdd-telemetry-ffi, libdd-tinybytes, libdd-trace-protobuf) need serde_json Value/from_str: features=["alloc"] is sufficient; full std is not required Also documents the default-features = false policy in workspace-deps-migration.md so future phases follow the same discipline.
c550154 to
d729024
Compare
Migrating build_common to a workspace dependency touches how downstream users of libdatadog integrate this internal build-tooling crate. Delay consolidating internal crates and keep this phase scoped to external dependencies (prost-build, protoc-bin-vendored, serde_json). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
FYI: as requested by the PHP team, I reverted the |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
2 participants
Summary
Phase 2 of the workspace dependencies migration, following phase 1 (#2253).
Adds four dependencies to
[workspace.dependencies]and migrates all leaf crates to useworkspace = true.Dependencies migrated
build_commonpath = "build-common"-fficrates +builder)prost-buildlibdd-ddsketch,libdd-trace-protobuf)protoc-bin-vendoredlibdd-ddsketch,libdd-trace-protobuf)serde_jsonFeature auditing (serde_json)
Each of the 22 leaf crates that previously used
serde_json = "1.0"(default features =std) was compiled individually withcargo check -p <crate> --all-targetswith no features first:serde_json.workspace = truelibdd-profiling-ffi,libdd-telemetry-ffi,libdd-tinybytes,libdd-trace-protobuf): useValueandfrom_strwhich need at least theallocfeature →features = ["alloc"]. Fullstdis not required.Validation
cargo check --workspace --exclude builder✅cargo +nightly-2026-02-08 fmt --all -- --check✅