Skip to content

refactor(gui): replace title color magic number with named constant #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
funa-tk merged 1 commit into from
Jul 10, 2026
Merged

refactor(gui): replace title color magic number with named constant #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/core/packetproxy/gui/GUIOption.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@

public class GUIOption {

private static final Color TITLE_FOREGROUND_COLOR = new Color(0, 238, 208);

private JFrame owner;

public GUIOption(JFrame owner) {
Expand All @@ -50,7 +52,7 @@ public GUIOption(JFrame owner) {

private JComponent createTitle(String title) throws Exception {
JLabel label = new JLabel(title);
label.setForeground(Color.decode("61136"));
label.setForeground(TITLE_FOREGROUND_COLOR);
label.setBackground(Color.WHITE);
label.setFont(FontManager.getInstance().getUICaptionFont());
label.setMaximumSize(new Dimension(Short.MAX_VALUE, label.getMinimumSize().height));
Expand Down