ci: run the examples-module tests and refresh the EngineDeck baseline#288
Merged
Conversation
The examples CI job only compiled the module and ran the generation smoke, so the examples' own tests (flagship layout-snapshot baselines, the examples-local theme helpers, the README banner renderer) ran nowhere in CI. That gap let a stale baseline sit unnoticed: the EngineDeck hero was deliberately crop-tightened (softPanel padding 30 -> 18) the day after its baseline was blessed, and the snapshot test has been failing locally ever since without anything catching it. Add a "Run examples tests" step to the examples job between compile and the generation smoke, and re-bless the EngineDeck baseline to the current render. The baseline diff is geometry-only (positions and sizes; no content changes), matching the crop change. Examples suite: 31 tests, 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The examples CI job only compiled the module and ran the generation smoke — the examples' own tests (flagship layout-snapshot baselines, the examples-local theme helpers, the README banner renderer) ran nowhere in CI. The gap had a concrete cost: the EngineDeck hero was deliberately crop-tightened (
softPanelpadding 30 → 18, commit4a77284c) the day after its baseline was blessed, andEngineDeckLayoutSnapshotTesthas been failing locally ever since with nothing catching it.What
Run examples testsstep to the existingExamples Generation Smoke Testjob, between compile and the generation run (job name unchanged — no branch-protection churn). The job already installs fonts/emoji/engine, so no new setup.engine-deck.jsonto the current render. Root cause verified — not OS drift (the siblingFinancialReportLayoutSnapshotTestsnapshot passes on the same machine): the example changed after the last bless. The baseline diff is geometry-only (positions/sizes, zero content changes), matching the crop commit.Tests
mvn -f examples/pom.xml test— 31 tests, 0 failures locally; this PR's CI run exercises the new step itself. Engine suite untouched.