Repository navigation
Merge usage ledger updates across processes; release 0.9.1 - #25
Merged
Merged
Conversation
Each process read usage.json once and wrote its own copy over the file, so concurrent processes lost each other's counts and the day caps saw only one process. Updates now add their delta to the file's current content under a lock file, and today(), blocked(), and describe() read the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lost counts in the usage ledger when several processes write it at once.
Each process read
usage.jsononce and then wrote its whole in-memory copy over the file on every update, so the last writer won. With several sessions running at once, the spend that/typesafe statusreports fell short of the real use, and theusdPerDay,requestsPerDay, andinputTokensPerDaycaps did not stop at their limit.recordStart,recordSuccess, andrecordFailurenow adds its delta to the file's current content under a lock file next to it (usage.json.lock, created exclusively), then writes atomically as before.today(),blocked(), anddescribe()read the file, so a day cap counts every process.UsageLedgergains an optionalflush()that adds any held delta, for a host that wants to drain it before exit.The last commit bumps the version to 0.9.1 and moves the changelog notes under
## 0.9.1.Verification:
npm run check: 153 tests, all pass.