fix(deps): next 16.3.3 — clears 2 critical unauthenticated RCE advisories - #414
Open
AminDhouib wants to merge 1 commit into
Open
fix(deps): next 16.3.3 — clears 2 critical unauthenticated RCE advisories#414AminDhouib wants to merge 1 commit into
AminDhouib wants to merge 1 commit into
Conversation
…ed RCE) Clears GHSA-p293-qw3h-jr36 and GHSA-2xp9-vwfh-vxw4 (critical RCE, next <16.3.3), GHSA-rgj7-g3m4-5g8c (sharp, transitively via next) and GHSA-2883-xcg3-v3hh (js-yaml 3.x, via a version-scoped override). pnpm audit --prod: 31 -> 22 findings, critical 2 -> 0, 9 cleared, 0 new.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two critical, unauthenticated RCE advisories in
nextwere published after thisfleet's last green dependency audit. They were caught by GetItDone's
Dependency Auditjob and are fleet-wide, not GetItDone-specific.next>=16.0.0 <16.3.3next>=16.0.0 <16.3.3sharp<0.35.4js-yaml>=3.0.0 <3.15.2p293 is RCE on Windows-hosted servers; 2xp9 is RCE in the Image Optimization API when
AVIF files are used. Neither needs authentication.
What changed
Only
package.jsonfiles and the lockfile. No workflow file, no source file.apps/landing/package.jsonnext(dep)16.2.1116.3.3apps/next-example/package.jsonnext(dep)16.2.1116.3.3apps/playground/package.jsonnext(dep)16.2.1116.3.3packages/next/package.jsonnext(devDep)16.2.1116.3.3package.jsonpnpm.overridesjs-yaml@3→3.15.2the 16.2 line; 16.3.3 is the smallest patched version anywhere in the 16 major.
sharpneeded no direct change. Nothing here declares it — it arrives undernext, andnext@16.3.3resolves it to 0.35.4, which clears both sharp advisoriesas a side effect. Confirmed in the regenerated lockfile.
js-yamlis transitive. The lockfile carried 3.14.1 and 3.14.2. Fixed with aversion-scoped
js-yaml@3override pinned to 3.15.2, so the 3.x consumers stayinside their own major. A blanket
js-yamloverride would have dragged them onto4.x, which removed
safeLoad/safeDump.One thing deliberately NOT changed
packages/next/package.jsondeclares"next": ">=15.0.0"as a peerDependency.That range does admit vulnerable versions (15.0.0 through 15.5.23), but it is the
published contract of this package, not an installed version. Raising it to
>=15.5.24would be a breaking change for every consumer on an older 15.x and wouldnot patch a single installed tree — the consumer's own lockfile decides that. Left
alone on purpose; flagging it here so the choice is visible rather than silent.
pnpm audit --prodbefore / afterRun with the repo's own package manager (
packageManager: pnpm@10.11.0, via corepack).Baseline from a pristine
git worktreeat base commit813756ed7450bba117c87bb9bf47c2cc7584c674, so the runs differ only by this diff.9 advisories cleared, 0 new, and the repo now has zero criticals in its production
tree.
What was verified locally, and what was not
pnpm install --lockfile-onlypnpm audit --prodbefore/afternext16.3.3,sharp0.35.4,js-yaml3.15.2 + 4.3.2git ls-files --eolon all 6 changed filesi/lf w/lfturbo run typecheckandturbo run buildwere NOT run locally, and this is not aclaim that they pass. A full install of this workspace pulls the Storybook, Angular,
Vue and Svelte toolchains plus a patched
@storybook/angular, which is notreproducible on the machine this branch was prepared on. CI is the gate — please do
not merge on a red build.
Deployment note
upupis Dokploy-tracked with 5 deployed units, so this PR is deliberately notbeing merged by automation — merging triggers a redeploy. Left for the owner's
review window.