fix: preserve leading zeros in HUC codes by casting to str - #42
Open
Ehakl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40
Problem
The
huc_cdvalue returned byload_site_data()indata_retrieval.pywas not explicitly cast to a string. When the NWIS API returns HUC codes with leading zeros (e.g.01080106for site01151500), pandas can silently cast the value to an integer, dropping the leading zero and producing1080106.Fix
Wrap
resp['huc_cd'].iloc[0]instr()on line 301 ofhydroshift/utils/data_retrieval.pyto ensure the HUC code is always stored as a string, preserving any leading zeros.This is a one-line change with no side effects — the value is only ever used for display in the
site_summary.mdtemplate.