Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 0 of the anonymous table box fixup work (split out from #783; based on #781's branch): generalizes anonymous node creation without changing behavior.
LayoutChildren::create_anonymous_block's body is extracted into a free function parameterized by kind:Since precomputed pseudos take their declarations from UA stylesheet rules,
default.cssgainsso the table-kind anonymous boxes (used by #783 on top of this) carry honest computed displays. The
Blockpath is a pure refactor; the table variants are unused here (#[allow(dead_code)]until #783 lands on top).cargo fmt/clippyclean; existing table/anonymous-cell tests pass.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/e0b69caedcd34e829ff73fb7ff216a75
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/e0b69caedcd34e829ff73fb7ff216a75?variant=devin-insiders
Requested by: @nicoburns
WPT results
71 newly passing, 19 newly failing (net +52).
Full diff (90 changed tests)
Generated by the WPT workflow.