Repository navigation
Clear JavaScript advisories and fix the nightly Security Scan - #144
Conversation
- Refreshed the vulnerable transitive packages in web, docs and mock-oauth (brace-expansion, fast-uri, picomatch, rollup, source-map-js, ws, @trpc/server, http-cache-semantics, js-yaml, form-data, path-to-regexp, proxy-addr) within their existing ranges. braces has no fixed release, so knip goes to 6.39 (it no longer uses fast-glob); dropped the knip ignores it reports as unneeded. - scripts/check_js_audit.sh (task sec:js) runs bun audit --audit-level=high on all three packages. CI runs it in web-tests, so an advisory fails the push that brings it in, and the nightly scan's audit job uses it too. - The scan's image job logs in to Docker Hub before Trivy pulls the published image. Fixes #143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 8 billable files and costs up to $2.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 12 minutes for your next included review. View limit details
Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Oct 13, 2026 1:57a.m. | Review ↗ | |
| Go | Oct 13, 2026 1:57a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Fixes #143.
Advisories
bun audit --audit-level=highreported 20 high-severity advisories inweb/.docs/had 7 andmock-oauth/had 3 (one critical); the scan didn't audit those two. All came in through build and test tooling.bun.lockwithin their existing version ranges: brace-expansion, fast-uri, picomatch, rollup, source-map-js, ws, @trpc/server, http-cache-semantics, js-yaml, form-data, path-to-regexp and proxy-addr.braceshas no fixed release, so knip goes from 5 to 6.39, which no longer depends on fast-glob. I also removed theknip.jsonignores knip 6 reports as unneeded.bun audit --audit-level=highnow passes in all three packages.Catching new advisories
scripts/check_js_audit.sh(task sec:js) audits web, docs and mock-oauth from their lockfiles, with no install needed.web-tests(a required check), so a push that brings in an advisory fails, instead of only the next nightly scan.js-auditjob (formerlyweb-audit) uses the same script.Image scan
docker.io/docspringcom/rack-gatewayneeds a login to pull. Anonymous requests get401 authentication required, so Trivy never scanned the image. Theimage-scanjob now logs in with the release workflow's Docker Hub secrets first.Checks