Repository navigation
fix: CLI rack status, trusted device TTL, approval denial reasons, admin alerts, dead CLI commands - #145
Conversation
…min alerts, dead CLI commands - `rack-gateway rack` shows the rack commands would use (--rack, then RACK_GATEWAY_RACK, then the current rack), not always the config's current rack (#133) - The MFA status response carries the trusted device TTL, and the web UI's "Trust this device" labels use it instead of a hardcoded 30 days (#134) - An API token refused by deploy_with_approval gets a 403 that says why, from its own newest request for the app (#136) - Security alerts go to the current unlocked admins, looked up when sent, instead of the admins at startup (#137) - Remove CLI commands the gateway always refuses: resources, certs, registries, instances keyroll/terminate and apps cancel (#138) Fixes #133, fixes #134, fixes #136, fixes #137, fixes #138 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 29 billable files and costs up to $7.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 1 minute for your next included review. View limit details
Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Oct 13, 2026 2:08a.m. | Review ↗ | |
| Go | Oct 13, 2026 2:08a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Summary
rack-gateway rackignores--rackandRACK_GATEWAY_RACK#133rack-gateway rackshows the rack that commands would use:--rack, thenRACK_GATEWAY_RACK, then the current rack. Before this, it always showed the config's current rack.RACK_GATEWAY_URLwith an API token still takes precedence.trusted_device_ttl_days. The web UI's "Trust this device/browser" labels show it instead of a hardcoded 30 days, and leave the duration out until it's known.deploy_with_approvalgets a 403 that says why. The reason comes from its own newest request for the app: it has none, or that request is pending, rejected, already deployed, expired, or approved but not for this upload, build, release or command. The token can already read its own requests, so the message reveals nothing new.resources,certs,registries,instances keyroll,instances terminateandapps cancel. The dead RBAC entries for them are tracked in Remove unused code and a finished migration path #141.The docs are updated for each change.
Fixes #133, fixes #134, fixes #136, fixes #137, fixes #138
Test plan
task go:lint,task go:test:unittask web:test,task web:lint:typecheck