Skip to content

fix: CLI rack status, trusted device TTL, approval denial reasons, admin alerts, dead CLI commands - #145

Merged
ndbroadbent merged 1 commit into
mainfrom
nathan/cli-ui-fixes
Oct 13, 2026
Merged

ndbroadbent merged 1 commit into
mainfrom
nathan/cli-ui-fixes

Conversation

@ndbroadbent

Copy link
Copy Markdown
Member

Summary

The docs are updated for each change.

Fixes #133, fixes #134, fixes #136, fixes #137, fixes #138

Test plan

  • task go:lint, task go:test:unit
  • task web:test, task web:lint:typecheck
  • docs build (link check)
  • CI

…min alerts, dead CLI commands

- `rack-gateway rack` shows the rack commands would use (--rack, then RACK_GATEWAY_RACK,
  then the current rack), not always the config's current rack (#133)
- The MFA status response carries the trusted device TTL, and the web UI's "Trust this
  device" labels use it instead of a hardcoded 30 days (#134)
- An API token refused by deploy_with_approval gets a 403 that says why, from its own
  newest request for the app (#136)
- Security alerts go to the current unlocked admins, looked up when sent, instead of the
  admins at startup (#137)
- Remove CLI commands the gateway always refuses: resources, certs, registries,
  instances keyroll/terminate and apps cancel (#138)

Fixes #133, fixes #134, fixes #136, fixes #137, fixes #138

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 29 billable files and costs up to $7.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 1 minute for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 61 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f00ee843-73d7-49f2-9e0d-64e7adbc715e
📥 Commits

Reviewing files that changed from the base of the PR and between 7614e42 and d70da8d.

⛔ Files ignored due to path filters (2)
  • internal/gateway/openapi/generated/swagger.json is excluded by !**/generated/**
  • web/src/api/types.generated.ts is excluded by !**/*.generated.*
📒 Files selected for processing (29)
  • docs/src/content/docs/integrations/deploy-approvals/workflow.mdx
  • docs/src/content/docs/integrations/email.mdx
  • docs/src/content/docs/security/rbac/permissions.mdx
  • docs/src/content/docs/user-guide/cli/commands.mdx
  • docs/src/content/docs/user-guide/cli/multi-rack.mdx
  • docs/src/content/docs/user-guide/mfa/trusted-devices.mdx
  • internal/cli/cli_rack.go
  • internal/cli/cli_test.go
  • internal/cli/convox_apps.go
  • internal/cli/convox_logs.go
  • internal/cli/convox_resources.go
  • internal/cli/rack.go
  • internal/cli/root.go
  • internal/gateway/app/setup.go
  • internal/gateway/handlers/auth_mfa_management.go
  • internal/gateway/handlers/dto.go
  • internal/gateway/proxy/approval_denial.go
  • internal/gateway/proxy/approval_denial_test.go
  • internal/gateway/proxy/token_permissions.go
  • internal/gateway/security/notifier.go
  • internal/gateway/security/notifier_test.go
  • web/src/api/openapi.json
  • web/src/api/schemas/handlersMFAStatusResponse.ts
  • web/src/components/account-security/enrollment-dialog.tsx
  • web/src/components/mfa-verification-form.test.tsx
  • web/src/components/mfa-verification-form.tsx
  • web/src/components/mfa-verification-form/form-sections.tsx
  • web/src/lib/time.test.ts
  • web/src/lib/time.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 7614e42...d70da8d on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Oct 13, 2026 2:08a.m. Review ↗
Go Oct 13, 2026 2:08a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@ndbroadbent
ndbroadbent merged commit 5998d18 into main Oct 13, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant