Sign what a release ships - #12
Merged
Merged
Conversation
The release already carries the distributions. What it did not carry was anything tying them to the run that produced them, so "this wheel came from that commit" was a claim with nothing behind it. The attestation is produced in the build job rather than in the job that creates the release: a later job holding the same artefact can only attest that it downloaded it, which is not the claim anyone wants to verify. PyPI-side PEP 740 attestations are unchanged; gh-action-pypi-publish produces those by default under Trusted Publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release already carries the distributions; what it did not carry was anything tying them to the run that produced them.
The attestation goes in the build job, not in the one that creates the release — a later job holding the same artefact can only attest that it downloaded it.
Verify with
gh attestation verify <file> --repo DrobyshevDev/mlango. PyPI-side PEP 740 attestations are untouched.Signed-Releasesis one of the five checks scoring 0 on this repository's Scorecard (currently 6.3, the highest in the organisation).Not exercised by this PR: the release path only runs on a published release.