Skip to content

feat: FINALV1GUILDRAIDSAFETY - Disallow readying up if not a guild raid - #31

Open
Good627 wants to merge 5 commits into
EdenGuild:masterfrom
Good627:FINALV1GUILDRAIDSAFETY
Open

Good627 wants to merge 5 commits into
EdenGuild:masterfrom
Good627:FINALV1GUILDRAIDSAFETY

Conversation

@Good627

@Good627 Good627 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a toggleable safety feature to disallow readying up in a raid preparation menu if the raid is not a Guild Raid (graid).

Behavior

  • Default: Disabled (
    equireGuildRaid = false\ in config).
  • Detection: Checks container slots of the raid menu for \guild raid available\ case-insensitively across hover names and lore lines, and verifies all players are opted in (blocks if any lore line contains \✖, \u2716, or \opted out).
  • Enforcement: Blocks clicks on ready slots (#33, #34, #35) with rejection note block sound.
  • Bypass: Unlike minimum gambits, Guild Raid Safety strictly blocks even when Shift-clicking (can be disabled in settings if needed).
  • Tooltip Warning: Tooltip warnings are inserted directly above 'Click to Ready Up' in item lore, with the minimum gambit warning positioned strictly above the guild raid warning.
  • Top-of-Screen Popup: When readying is blocked, a top-of-screen notification box is displayed framed in a gold/wood border featuring the Eden Logo on the left and colored warning text. Shift-clicking with only minimum gambits enabled bypasses cleanly without showing the popup.
  • Unit Tests: Full unit test coverage in \RaidGambitSafetyTest\ for hover name, lore line detection, opt-in/opt-out checks, click evaluation, and popup lifecycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant