test: add testIDs for send flow UI automation#6033
Open
j0ntz wants to merge 1 commit into
Open
Conversation
Add testIDs to the send address tile buttons (enter, myself, scan, paste) and the SafeSlider confirm thumb so UI tests can drive the send flow by stable selectors instead of brittle text or coordinate matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Test-infrastructure only. No behavior or visual changes.
Adds stable
testIDprops so UI automation can drive the send flow by selector instead of brittle text or coordinate matching:AddressTile2:sendAddressEnter,sendAddressMyself,sendAddressScan,sendAddressPaste.SafeSlider:confirmSliderThumbon the draggable thumb (the id the shared maestro confirm-slider flow already expects).These were added while verifying the TON duplicate-transaction fix (edge-currency-accountbased#1059); the send flow had no stable selectors. Snapshot files updated to reflect the new props. Related to Asana task.
Note
Low Risk
Additive test-only props with no logic, styling, or navigation changes.
Overview
Test automation hooks only — no user-visible or behavioral changes.
Adds
testIDprops so Maestro (and similar) can target send-flow controls by stable selectors:AddressTile2:sendAddressEnter,sendAddressMyself(when self-transfer is shown),sendAddressScan,sendAddressPasteon the empty-recipient action buttons.SafeSlider:confirmSliderThumbon the draggable thumb (shared by send, swap confirmation, accelerate-tx, etc.).CHANGELOG documents the change; Jest snapshots were regenerated to include the new props.
Reviewed by Cursor Bugbot for commit 4207c64. Bugbot is set up for automated code reviews on this repo. Configure here.