add musical-symbols as fallback font for preview paragraphs#707
Open
SteffenAstheimer wants to merge 1 commit into
Open
add musical-symbols as fallback font for preview paragraphs#707SteffenAstheimer wants to merge 1 commit into
SteffenAstheimer wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the rendering problem of musical symbols explained in #423.
Apparently Chrome and Firefox have a fallback for musical symbols, while Safari doesn't. (At least I could only recreate the issue with Safari.) I added
musical-symbolsto the font-family for.popover-body psince the summary is flattened to plain text aswell, so this should work for the whole popover content.I couldn't find any false positives so far and hope that this should do the trick.