fix(FFESUPPORT-883): remediate July 2026 dependabot vulnerabilities - #126
Merged
Conversation
Re-resolve dev-only transitive deps to patched, in-range versions: - js-yaml 3.14.2 -> 3.15.0 (GHSA-h67p-54hq-rp68, via jest/istanbul) - js-yaml 4.1.1 -> 4.3.0 (GHSA-h67p-54hq-rp68, via eslint + api-documenter) - @babel/core 7.29.0 -> 7.29.7 (GHSA-4x5r-pxfx-6jf8, via jest) @microsoft/api-documenter pins js-yaml ~4.1.0 (capped at the vulnerable 4.1.x) even at its latest release, so a scoped resolution forces it to ^4.2.0 - the one path with no consumable upstream fix. Dev-only doc tool; js-yaml 4.x API is stable across minors. Rationale recorded in resolutionRationales. No runtime dependency moved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates dev-only transitive dependencies to remediate Dependabot-reported vulnerabilities, primarily by re-resolving the Yarn v1 lockfile and adding a targeted Yarn resolutions override for the @microsoft/api-documenter → js-yaml constraint.
Changes:
- Bumps the Babel toolchain dependency set in
yarn.lockto@babel/core@7.29.7(and associated@babel/*packages as resolved). - Updates
js-yamlresolutions inyarn.lockto patched versions (3.15.0for^3.13.1and4.3.0for^4.1.0/~4.1.0paths). - Adds a scoped Yarn resolution and rationale to force
@microsoft/api-documenteroffjs-yaml ~4.1.0and onto a patchedjs-yaml4.x version.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yarn.lock | Re-resolves transitive dev dependencies to patched versions (notably @babel/core and js-yaml). |
| package.json | Adds a scoped resolutions override and corresponding resolutionRationales entry for @microsoft/api-documenter/js-yaml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
🤖 Response from codex: LGTM
(codex ran locally via |
greghuels
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated from Claude
Remediates the 3 open Dependabot alerts in
node-server-sdk— all dev-only transitive dependencies. Jira: https://datadoghq.atlassian.net/browse/FFESUPPORT-883Advisories closed
Approach
Mostly a lockfile-only re-resolution to patched in-range versions. One scoped resolution was required:
@microsoft/api-documenterpinsjs-yaml ~4.1.0(capped at the vulnerable 4.1.x) even at its latest release (7.30.8), so there is no consumable upstream fix for that path —"@microsoft/api-documenter/js-yaml": "^4.2.0"forces it to 4.3.0. It's a dev-only doc-gen tool and js-yaml's 4.x API is stable across minors; the rationale is recorded inresolutionRationales. No runtime/prod dependency moved.How the tests/CI protect this change
yarn install --frozen-lockfilepasses → lockfile consistent withpackage.json.yarn typecheck✓,eslint '**/*.{ts,tsx}'✓ (eslint parses YAML config via js-yaml — a bad bump fails here).yarn test:unit— 115 tests / 2 suites pass (jest via @babel/core;yarn docs/ API Extractor also runs api-documenter → js-yaml at install).Deferred advisories
None — all 3 open Dependabot alerts are addressed; none left dismissed/auto-dismissed.