Update CI to follow how we run tests#228
Open
furtib wants to merge 12 commits into
Open
Conversation
furtib
force-pushed
the
ci-rework
branch
5 times, most recently
from
e7fe957 to
ac54a71
Compare
Contributor
|
Well, the new docs suggests |
furtib
force-pushed
the
ci-rework
branch
9 times, most recently
from
7349122 to
2a3ad45
Compare
furtib
force-pushed
the
ci-rework
branch
7 times, most recently
from
ab23bc4 to
bb3d53a
Compare
furtib
force-pushed
the
ci-rework
branch
2 times, most recently
from
8d75556 to
117e491
Compare
Update dev.yaml with required packages
Add patch to micromamba (used in FOSS tests)
Szelethus
requested changes
Jun 15, 2026
Szelethus
left a comment
Szelethus
left a comment
Contributor
There was a problem hiding this comment.
This patch, I think, is a little too large in scope.
Comment on lines
+3
to
+4
| "7.7.1", | ||
| "8.5.1" |
Contributor
There was a problem hiding this comment.
Why is this change necessary in this specific patch? Why not bump bazel 8 to up 8.6?
Contributor
Author
There was a problem hiding this comment.
Micromamba didn't have 8.5.0 or 7.7.0. No reason for not updating straight to 8.6.
Contributor
Author
There was a problem hiding this comment.
Yes, there is a reason:
The Bazel version 8.6.0 does not have thebazel --version command, which FOSS tests depend on.
To keep the scope of the patch minimal, this bump should be a separate PR.
Bazel 8.5.1 do while 8.6.0 doesn't have the `bazel --version` functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The way CI works and how tests are run locally (#218) shifted dramatically, so I updated the CI to correctly reflect how these tests were supposed to be run locally.
What:
bazel test //...to CINote:
init.shscript does not allow users to specify program versions with flags (e.g.bazel=7.7.1), which this other method does.ci.yamlmicromamba environment. This was done so that the Bazel version is controllable with command-line arguments.dev.yamlfile.Addresses:
none
depends on: #233