Fixed issues with --features=external_include_paths#243
Open
furtib wants to merge 5 commits into
Open
Conversation
Szelethus
requested changes
Jun 16, 2026
Szelethus
left a comment
Szelethus
left a comment
Contributor
There was a problem hiding this comment.
Bazel 6.5.0 CI jobs break:
Error: 'CompilationContext' value has no field or method 'external_includes'
If this is a bazel 6 specific issue, then I suggest this might be a sign that it is time to officially stop supporting it.
Comment on lines
+144
to
+147
| for quote_include in compilation_context.quote_includes.to_list(): | ||
| if len(quote_include) == 0: | ||
| quote_include = "." | ||
| options.append(QUOTE_INCLUDE + quote_include) |
Contributor
There was a problem hiding this comment.
This doesn't have a test.
furtib
commented
Jun 16, 2026
|
|
||
| Limitations: | ||
| ------------ | ||
| In Bazel 6, we do not support using the `--features=external_include_paths` flag. |
Contributor
Author
There was a problem hiding this comment.
I think it makes sense not to explicitly drop Bazel 6, and keep it in a limited, but working state.
Contributor
There was a problem hiding this comment.
I disagree. I don't want to half-support a bazel major version we already agreed on dropping.
Contributor
Author
There was a problem hiding this comment.
Okay, let's drop Bazel 6 then.
furtib
force-pushed
the
fix-external-include-paths
branch
from
14fc533 to
5e1a45e
Compare
furtib
force-pushed
the
fix-external-include-paths
branch
from
fa5bbb7 to
e037af2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want to support running analysis with
--features=external_include_paths.What:
external_includesto compile commands.Addresses:
Fixes: #236