Fix Java 21 build configuration - #150
Open
SamTheDevDE wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This fixes the Java version mismatch in the build setup.
The project already uses a Java 21 toolchain, but compiles using Java 17. I also noticed that the Github Actions workflow was also using Java 17.
That no longer works with some of the dependencies, which now require a more up to date version aka Java 21.
Changes
Why?
Without this, the build fails during dependency resolution with errors like:
Dependency resolution is looking for a library compatible with JVM runtime version 17, but the dependency is only compatible with JVM runtime version 21 or newer.This just makes the build configuration match the Java version the project is already expecting.
Testing
Tested with:
./gradlew clean eternaleconomy-core:shadowJarthe build completes successfully after the change.