Conversation
- sdd filter expression evaluator to GUI - filter is selectable for all expression properties and configured through the existing SearchFilterConfigurationPanel. - condition editor now offers Script and Filter instead of the script editor only.
- write the filter into the expression even when the condition is still empty, LambdaModel skips its setter on a null target - update the filter field on blur, panels closing with a plain ajax link never submit the form and dropped the typed filter - set outputMarkupId on SearchFilterConfigurationPanel, it re-renders itself when switching between XML and query - style the filter buttons as btn-light border, btn-primary is reserved for primary actions
- add a condition indicator to the mapping tables, opening a drawer that writes the condition only on Apply - edit the script of an expression on a copy too, so closing the drawer discards the changes - drop an expression whose evaluator was left blank instead of storing it
- delete obsolete ExpressionEditorPanel and ExpressionTypeDto - delete the dead members of ExpressionUtil that were left without a caller
skublik
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writes the condition only on Apply
discards the changes
caller