BPE: replace solution code, fix Solution button opening the question - #30
Merged
Merged
Conversation
- BPE-q3-SOLN.ipynb: swap in the implementation and tests from Tar-ive/dl_basics Byte_Pair_Encoding_Scratch.ipynb. The markdown problem cell is unchanged. This also replaces the old test cell, which was cut off mid-call (`test_get_`). - website/src/data/questions.ts: v2-3 solutionPath pointed at the question notebook, so "Open Solution in Colab" / "Download Solution" opened the question. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QpBMRkd6QHXSsjd6bvPjUc
|
Someone is attempting to deploy a commit to the exorust's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Exorust
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1.
llm/Byte-Pair-Encoder/BPE-q3-SOLN.ipynbSwapped the two code cells (implementation + tests).
""as the end-of-word marker.merge_vocabadds it back aftersplit()so words don't lose it.test_get_and threw aNameError.2.
website/src/data/questions.tsFor
v2-3(Byte Pair Encoding),solutionPathpointed atBPE-q3.ipynb, the question notebook. Because of that, Open Solution in Colab and Download Solution both opened the question. It now points atBPE-q3-SOLN.ipynb.problems.generated.tsalready had the right path.Verification
python3 scripts/validate_specs.py byte-pair-encoder→ PASSpython3 scripts/generate.py check→ 68 manifests checked, 0 problems