Send empty bank account when disabling payments#95699
Open
ShridharGoel wants to merge 1 commit into
Open
Conversation
Pujan92
approved these changes
Jul 9, 2026
Pujan92
left a comment
Contributor
There was a problem hiding this comment.
LGTM! There is one issue where to add bank account again properly you need to go to wallet first or maybe need to revisit the workflow page. But that doesn't seems to issue of this PR.
Screen.Recording.2026-07-09.at.23.59.40.mov
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When disabling Make or track payments, App now sends
bankAccountID: 0toSetWorkspaceReimbursement.Before this change, App sent the existing workspace bank account ID even when the new reimbursement choice was
reimburseNo. That made the backend treat the request like a bank account update. Payments Admins can manage Workflows > Payments, but they may not have access to the workspace owner's bank account, so the request failed.This keeps the existing bank account ID for enabling or changing payments, and only clears it for the disable path.
Fixed Issues
$ #95536
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari